Skip to content

Since Java SE 17 old language codes not converted #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sv99 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Since Java SE 17 old language codes not converted #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/test/java/com/android/tools/build/bundletool/model/utils/ResourcesUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,10 +246,13 @@ public void filter_removesEmptyPackagesTypesAndEntries() throws Exception {
public void resourcesLocaleConversions_oldLanguageCodes() {
// This documents that our converter will use old ISO-639 language codes for backward
// compatibility.
// Since Java SE 17, this is no longer the case.

assertThat(ResourcesUtils.convertLocaleToLanguage("he")).isEqualTo("iw");
assertThat(ResourcesUtils.convertLocaleToLanguage("yi")).isEqualTo("ji");
assertThat(ResourcesUtils.convertLocaleToLanguage("id")).isEqualTo("in");
if (System.getProperty("java.version").compareTo("17") < 0) {
assertThat(ResourcesUtils.convertLocaleToLanguage("he")).isEqualTo("iw");
assertThat(ResourcesUtils.convertLocaleToLanguage("yi")).isEqualTo("ji");
assertThat(ResourcesUtils.convertLocaleToLanguage("id")).isEqualTo("in");
}
}

@Test
Expand Down