Skip to content

Accumulate unknowns into a set to avoid intermediate duplication. #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Nov 12, 2025
Merged

Accumulate unknowns into a set to avoid intermediate duplication. #864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions runtime/src/main/java/dev/cel/runtime/AccumulatedUnknowns.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.List;
import java.util.HashSet;
import java.util.Set;

/**
* An internal representation used for fast accumulation of unknown expr IDs and attributes. For
Expand All @@ -27,14 +28,14 @@
*/
final class AccumulatedUnknowns {
private static final int MAX_UNKNOWN_ATTRIBUTE_SIZE = 500_000;
private final List<Long> exprIds;
private final List<CelAttribute> attributes;
private final Set<Long> exprIds;
private final Set<CelAttribute> attributes;

List<Long> exprIds() {
Set<Long> exprIds() {
return exprIds;
}

List<CelAttribute> attributes() {
Set<CelAttribute> attributes() {
return attributes;
}

Expand All @@ -55,19 +56,20 @@ static AccumulatedUnknowns create(Collection<Long> ids) {
}

static AccumulatedUnknowns create(Collection<Long> exprIds, Collection<CelAttribute> attributes) {
return new AccumulatedUnknowns(new ArrayList<>(exprIds), new ArrayList<>(attributes));
return new AccumulatedUnknowns(new HashSet<>(exprIds), new HashSet<>(attributes));
}

private static void enforceMaxAttributeSize(
List<CelAttribute> lhsAttributes, List<CelAttribute> rhsAttributes) {
int totalSize = lhsAttributes.size() + rhsAttributes.size();
if (totalSize > MAX_UNKNOWN_ATTRIBUTE_SIZE) {
Set<CelAttribute> lhsAttributes, Set<CelAttribute> rhsAttributes) {
if (lhsAttributes.size() + rhsAttributes.size() > MAX_UNKNOWN_ATTRIBUTE_SIZE) {
throw new IllegalArgumentException(
"Exceeded maximum allowed unknown attributes: " + totalSize);
String.format(
"Exceeded maximum allowed unknown attributes when merging: %s, %s",
lhsAttributes.size(), rhsAttributes.size()));
}
}

private AccumulatedUnknowns(List<Long> exprIds, List<CelAttribute> attributes) {
private AccumulatedUnknowns(Set<Long> exprIds, Set<CelAttribute> attributes) {
this.exprIds = exprIds;
this.attributes = attributes;
}
Expand Down