Skip to content

feat: enable lfs for git origin #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1-ashraful-islam wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: enable lfs for git origin #323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion java/com/google/copybara/git/GitModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,12 @@ public GitModule(Options options) {
+ " fall back to the 'ref' param.\n"
+ "This is intended to help migrating to the new standard of using 'main'"
+ " without breaking users relying on the legacy default."),
@Param(
name = "enable_lfs",
defaultValue = "False",
named = true,
positional = false,
doc = "If true, Large File Storage support is enabled for the origin."),
@Param(
name = "credentials",
allowedTypes = {
Expand All @@ -332,6 +338,7 @@ public GitOrigin origin(
Object describeVersion,
Object versionSelector,
Boolean primaryBranchMigration,
Boolean enableLfs,
@Nullable Object credentials,
StarlarkThread thread)
throws EvalException {
Expand Down Expand Up @@ -370,7 +377,7 @@ public GitOrigin origin(
? githubPostSubmitApprovalsProvider(
fixedUrl, SkylarkUtil.convertOptionalString(ref), credentialHandler)
: approvalsProvider(url),
/* enableLfs= */ false,
enableLfs,
credentialHandler
);
}
Expand Down