cmake: Restrict check for CRC32C intrinsic to aarch64#61
Open
hebasto wants to merge 1 commit intogoogle:mainfrom
Open
cmake: Restrict check for CRC32C intrinsic to aarch64#61hebasto wants to merge 1 commit intogoogle:mainfrom
hebasto wants to merge 1 commit intogoogle:mainfrom
Conversation
The HAVE_ARM64_CRC32C test can erroneously pass when building on armv7, resulting in a broken library and failed tests. This change addresses the issue by narrowing the check to aarch64 platforms.
Author
|
Friendly ping @pwnall :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HAVE_ARM64_CRC32Ctest can erroneously pass when building on armv7:That results in a broken library and failed tests.
This PR addresses the issue by narrowing the check to aarch64 platforms.