Permit compilation under the rc of cmake 4.0.0#67
Open
eddelbuettel wants to merge 1 commit intogoogle:mainfrom
Open
Permit compilation under the rc of cmake 4.0.0#67eddelbuettel wants to merge 1 commit intogoogle:mainfrom
eddelbuettel wants to merge 1 commit intogoogle:mainfrom
Conversation
|
This was fixed in #68 and this pull can be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
crc32ccode is used under an (eoponymous) R package I look after. I was just informed by the maintainer of the CRAN repo for R that it no longer builds under the release candidate 4 of cmake 4.0.0.I was able to a) verify this and b) establish that the recommended course of action form switching from an (outdated for cmake 4) minimum version to the lowest support (3.5) in a min..max format also listing the one tested (here 4.0) works.
The simple one-line change below implements this. I cannot really tell if a minimum of cmake 3.5 (released in 2016) is viable for everyone or not. If you don't think this flies, please just ignore the PR. I will make this change in my [downstream R package to remain buildable at CRAN.
Thanks of course thanks for crc32c!