Fix issue 236: Repeated --import_dirs in cpp_golden_test#238
Closed
AaronWebster wants to merge 9 commits intomasterfrom
Closed
Fix issue 236: Repeated --import_dirs in cpp_golden_test#238AaronWebster wants to merge 9 commits intomasterfrom
AaronWebster wants to merge 9 commits intomasterfrom
Conversation
Optimized the generated C++ code for structures with conditional fields
by identifying and caching repeated subexpressions (e.g., tag reads)
in the `Ok()`, `Equals()`, and `UncheckedEquals()` methods.
This approach uses a two-pass generation strategy:
1. Count usage of existence condition subexpressions.
2. Generate code where frequently used subexpressions are cached in
local variables at the method scope, while unique expressions are
inlined.
This reduces redundant computations (CPU optimization) without
introducing excessive stack usage for unique conditions (Memory
optimization).
Also updated test infrastructure to support passing compiler flags to
golden tests, fixing `no_enum_traits_golden_test`.
Added `testdata/many_conditionals.emb` and `compiler/back_end/cpp/testcode/many_conditionals_benchmark.cc`
to verify performance of conditional fields.
Performance Analysis (10,000 iterations x 100 tags on `testdata/many_conditionals.emb`):
- Baseline Runtime: ~1.83s
- Optimized Runtime: ~0.21s (Speedup: ~8.7x)
Binary Size Impact (many_conditionals_benchmark, -c opt):
- Baseline: 57848 bytes (text: 56112)
- Optimized: 30472 bytes (text: 28736) -> ~47% reduction
Co-authored-by: AaronWebster <3766083+AaronWebster@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #236 by deduplicating import_dirs in cpp_golden_test. It also formats python files with black.