Open
Conversation
Contributor
poweifeng
commented
Mar 5, 2026
poweifeng
commented
- In finish(), instead of block to wait for read pixels to finish, we poll the state of the counter to ensure that all the readbacks are complete. This allows us to complete the readpixel callbacks by advancing webgpu's internal callback counter.
- Remove all the redundant flushes that are no longer needed now that buffer upload is put on the command queue.
- Add a convenience method for getting swapchain dimensions. Will be useful.
- Add webgpu as a valid backend for running backend tests on linux (now that it no longer deadlocks).
- In finish(), instead of block to wait for read pixels to finish, we poll the state of the counter to ensure that all the readbacks are complete. This allows us to complete the readpixel callbacks by advancing webgpu's internal callback counter. - Remove all the redundant flushes that are no longer needed now that buffer upload is put on the command queue. - Add a convenience method for getting swapchain dimensions. Will be useful. - Add webgpu as a valid backend for running backend tests on linux (now that it no longer deadlocks).
yrcloud
reviewed
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.