Skip to content

matdbg: prefer msl when running on metal#9780

Merged
poweifeng merged 2 commits intomainfrom
pf/matdbg-fix-metal
Mar 6, 2026
Merged

matdbg: prefer msl when running on metal#9780
poweifeng merged 2 commits intomainfrom
pf/matdbg-fix-metal

Conversation

@poweifeng
Copy link
Contributor

Keeping ShaderLanguage::UNSPECIFIED will return metal library as the preferred language on metal. Here we just make it more explicit that matdbg needs msl.

@poweifeng poweifeng added the internal Issue/PR does not affect clients label Mar 6, 2026
@poweifeng poweifeng requested review from bejado and pixelflinger March 6, 2026 19:58
Copy link
Member

@bejado bejado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Keeping ShaderLanguage::UNSPECIFIED will return metal library
as the preferred language on metal.  Here we just make it more
explicit that matdbg needs msl.

Fixes #9372
@poweifeng poweifeng force-pushed the pf/matdbg-fix-metal branch from a626b06 to 4b388d5 Compare March 6, 2026 20:08
@poweifeng poweifeng enabled auto-merge (squash) March 6, 2026 21:17
@poweifeng poweifeng merged commit 9a14e54 into main Mar 6, 2026
17 checks passed
@poweifeng poweifeng deleted the pf/matdbg-fix-metal branch March 6, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Issue/PR does not affect clients

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants