Skip to content

Add --ts-undefined-for-optionals command line option #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ibc wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Add --ts-undefined-for-optionals command line option #8861

ibc wants to merge 19 commits into from
+1,307 −55

Conversation

@ibc
Copy link

@ibc ibc commented Dec 17, 2025 •
edited
Loading

Details

@ibc
Add --ts-undefined-for-optionals command line option
524030f 
# Details

- Fixes google#7656
- Added a new `--ts-undefined-for-optionals` command line option for `flatc`.
- If enabled, generated TypeScript code uses `undefined` for optional fields rather than `null`.
@github-actions github-actions bot added python c++ javascript typescript codegen Involving generating code from schema labels Dec 17, 2025
@ibc ibc mentioned this pull request Dec 17, 2025
Open
@ibc
Copy link
Author

ibc commented Dec 17, 2025

Note for myself: run sh scripts/clang-format-git.sh after C++ changes.

@ibc
Copy link
Author

ibc commented Dec 18, 2025

This is ready.

@ibc ibc marked this pull request as ready for review December 18, 2025 12:01
@bjornharrtell bjornharrtell self-requested a review December 18, 2025 12:05
bjornharrtell
bjornharrtell previously approved these changes Dec 18, 2025
View reviewed changes
Copy link
Collaborator

@bjornharrtell bjornharrtell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some perhaps unnecessary source format changes but otherwise looks like solid work

@ibc
Copy link
Author

ibc commented Dec 18, 2025

Some perhaps unnecessary source format changes but otherwise looks like solid work

Could you detail which unnecessary source format changes you mean? I've run sh scripts/clang-format-git.sh as documented and on TS and Python files I've followed existing syntax.

@bjornharrtell
Copy link
Collaborator

bjornharrtell commented Dec 18, 2025

@aardappel I think it's is good to go but can't merge due to the test failure for swift which I would think is unrelated to this PR.

@jmillan
Copy link
Contributor

jmillan commented Dec 18, 2025

@aardappel I think it's is good to go but can't merge due to the test failure for swift which I would think is unrelated to this PR.

The error is due to a HTTP download timeout. Probably fixable by re-running the GH action.

@ibc
Copy link
Author

ibc commented Dec 18, 2025

@aardappel I think it's is good to go but can't merge due to the test failure for swift which I would think is unrelated to this PR.

It seems a network issue. Maybe re-running the job could work? Note: I cannot rerun it.

@bjornharrtell
Copy link
Collaborator

bjornharrtell commented Dec 18, 2025

@aardappel I was able to trigger re-run and it seems to work now.. but can't because of this:

image

No idea what that means.

@aardappel
Copy link
Collaborator

aardappel commented Dec 18, 2025

afaik @dbaileychess has locked the repo for some to changes how things are set up.. we'll have to wait till he is done before further PRs can get merged.

@dbaileychess
Copy link
Collaborator

dbaileychess commented Dec 19, 2025

I'm trying to minimize changes while I am working on merging the last 6 months of changes back into Google. Hopefully I can finish tonight or tomorrow, can this wait?

dbaileychess
dbaileychess requested changes Dec 19, 2025
View reviewed changes
@ibc ibc requested a review from aardappel as a code owner December 19, 2025 11:11
@ibc
Copy link
Author

ibc commented Dec 19, 2025

I'm trying to minimize changes while I am working on merging the last 6 months of changes back into Google. Hopefully I can finish tonight or tomorrow, can this wait?

Sure, no hurries. BTW I've addressed feedback already.
Thanks a lot.

@jtdavis777 jtdavis777 added the ready-for-merge This PR has been approved by a maintainer and is ready for merge by a code owner label Dec 22, 2025
@abhay-agarwal abhay-agarwal mentioned this pull request Jan 4, 2026
Open
@github-actions github-actions bot added the swift label Jan 12, 2026
ibc
ibc commented Jan 12, 2026
View reviewed changes
@ibc
Copy link
Author

ibc commented Jan 12, 2026

Hi @dbaileychess, I've merged master into this PR. Can we move on?

@ibc ibc requested a review from bjornharrtell January 12, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aardappel aardappel Awaiting requested review from aardappel

@dbaileychess dbaileychess Awaiting requested review from dbaileychess dbaileychess is a code owner

@bjornharrtell bjornharrtell Awaiting requested review from bjornharrtell

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

c++ codegen Involving generating code from schema javascript python ready-for-merge This PR has been approved by a maintainer and is ready for merge by a code owner swift typescript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TS] Feature Request: Make optional field getters return undefined (instead of null) if the value is not set

6 participants

@ibc @bjornharrtell @jmillan @aardappel @dbaileychess @jtdavis777