Skip to content

Conversation

@m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Nov 4, 2025

Taken from the upstream repo https://github.com/agyeiagyeiagyei/Crispy at commit agyeiagyeiagyei/Crispy@ca9ec78.

PR Checklist:

PR

  • The PR is in the Traffic Jam Board (Project > Traffic Jam Board)
  • It has the correct labels (upgrade, new font, specific language)
  • The PR is linked to the corresponding issue

QA

  • Fontspector checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 and 3 regression checks for revisions on all projects that are currently in production
  • The article has no typos, images are properly linked and correctly sized
  • OFL.txt contains the correct license URL (https://openfontlicense.org)

Specifics

  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.

Release

  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • minisite_url definition in the METADATA.pb file for commissioned projects
  • tags are added for NEW FONTS

@emmamarichal emmamarichal linked an issue Nov 5, 2025 that may be closed by this pull request
@emmamarichal
Copy link
Collaborator

Review - WIP -

@m4rc1e
I can see several interpolations issues:
Screenshot 2025-11-05 at 11 49 37
Screenshot 2025-11-05 at 13 38 27
Screenshot 2025-11-05 at 13 38 54
Screenshot 2025-11-05 at 13 39 45

Crispy[RXAD,XOPQ,XTRA,YOPQ].pdf

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Nov 5, 2025

Thank you cc @agyeiagyeiagyei

@emmamarichal emmamarichal added the -- Needs Upstream Resolution Upstream fix required before moving forward label Nov 6, 2025
@emmamarichal emmamarichal self-requested a review November 6, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-- Needs Upstream Resolution Upstream fix required before moving forward I New Font

Projects

Status: PR GF

Development

Successfully merging this pull request may close these issues.

Add Crispy

2 participants