fix: do not mutate std.removeAt parameters #812
Merged
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarelit
force-pushed
the
fix_807_removeAt
branch
from
794cad0 to
b961f92
Compare
stephenamar-db
pushed a commit
to databricks/sjsonnet
that referenced
this pull request
Jun 19, 2025
…r. (#437) Motivation: Add a test for std.removeAt, which should not modify the parameter. ported from go-jsonnet refs: google/go-jsonnet#812
Contributor
Author
|
@johnbartholomew may I kindly ask for your review? |
Collaborator
johnbartholomew
left a comment
johnbartholomew
left a comment
There was a problem hiding this comment.
Looks good, just a file formatting nit (missing newline at end of file).
| return nil, err | ||
| } | ||
|
|
||
| newArr := append(arr.elements[:idx], arr.elements[idx+1:]...) |
Collaborator
There was a problem hiding this comment.
Go's funky append() behaviour strikes again.
zarelit
force-pushed
the
fix_807_removeAt
branch
from
b961f92 to
9246e24
Compare
zarelit
force-pushed
the
fix_807_removeAt
branch
from
9246e24 to
268c15a
Compare
Collaborator
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #807