fix(imports): Cache the error too in importAST(). #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug was that a non-nil error was not returned when the cached Node was returned. Fix: Just cache both. The other possibility was not to cache when there is an error. But that broke a test in the linter. Fixes google#822
Collaborator
|
Thanks for the bug report, and the fix! This looks good, I'll just rebase it. |
johnbartholomew
force-pushed
the
rudo.thomas/fix-cached-import-syntax-error
branch
from
939a751 to
3d41737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was that a non-nil error was not returned when the cached Node was returned. Fix: Just cache both.
The other possibility was not to cache when there is an error. But that broke a test in the linter.
Fixes #822