Refactor: Update GooDB.FetchPkg to accept goolib.PackageInfo.#199
Merged
nguyen-phillip merged 10 commits intogoogle:masterfrom Mar 6, 2026
Merged
Refactor: Update GooDB.FetchPkg to accept goolib.PackageInfo.#199nguyen-phillip merged 10 commits intogoogle:masterfrom
nguyen-phillip merged 10 commits intogoogle:masterfrom
Conversation
The FetchPkg function now takes a goolib.PackageInfo and uses it to match the specific package state, including version and architecture, rather than just the package name. Call sites have been updated to pass the full PackageInfo.
Updated version to 3.3.0 and added release notes for the new version.
nguyen-phillip
approved these changes
Mar 5, 2026
Collaborator
nguyen-phillip
left a comment
nguyen-phillip
left a comment
There was a problem hiding this comment.
Some minor nits about existing code, but LGTM given that it should still fall back to old behavior if there's no exact match.
nguyen-phillip
requested changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FetchPkg function now takes a goolib.PackageInfo and uses it to match the specific package state, including version and architecture, rather than just the package name. Call sites have been updated to pass the full PackageInfo.