Fix #1053: Handle SMTP servers that don't support STARTTLS #1156
+131
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRR crashed when sending emails if the SMTP server didn't support STARTTLS. The code tried to use STARTTLS without checking if the server actually had it.
What I fixed
Check if server supports STARTTLS before trying to use it
Added a "strict mode" option - fails if STARTTLS is required but missing (good for production)
Default mode just logs a warning and sends anyway (backward compatible)
Better error messages when auth fails
Files changed
email_alerts.py - the actual fix
server.py - new smtp_starttls_strict config option
email_alerts_test.py - 5 new tests
For users :
If your server doesn't support STARTTLS, just set Worker.smtp_starttls: False in your config. Everything else works the same as before.