-
Notifications
You must be signed in to change notification settings - Fork 54
Fix incorrect package name in uistateadapter Utils #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @helpingstar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a structural inconsistency by correcting the package name and file location of a utility file, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses the incorrect package name in Utils.kt, moving it from a placeholder com.example package to the project's standard com.google.jetpackcamera.ui.uistateadapter. The import paths in all dependent files have been updated accordingly. The changes are correct and well-executed.
As a suggestion for future improvement, the getSelectableListFromValues function in Utils.kt could be refactored. Its KDoc parameter names are out of sync with the function signature, and the implementation can be made more concise by using a member reference for the .map operation (e.g., .map(SingleSelectableUiState::SelectableUi)). This would improve readability and align with Kotlin best practices, as encouraged by the repository's style guide (lines 22 and 64).
Fixes #423
Summary
com.example.uistateadaptertocom.google.jetpackcamera.ui.uistateadapterChanges
The Utils.kt file was using
com.example.*package which is typically a placeholder name. This PR aligns it with the project's standard package structure.