-
Notifications
You must be signed in to change notification settings - Fork 54
Update Capture Button visuals #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: temcguir/capture_button_disabled_state
Are you sure you want to change the base?
Update Capture Button visuals #461
Conversation
f12a849 to
d9398ce
Compare
|
/gemini summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request does a great job of updating the CaptureButton component's appearance and behavior. The changes align well with the design mocks, and the fixes for VIDEO_ONLY mode and volume button capture are significant improvements. The refactoring of the animation logic using updateTransition and the introduction of InteractionSource are excellent choices that follow Compose best practices. The simplification of the preview composables is also a welcome change that improves maintainability.
I've left a couple of comments: one to address a logic regression that could cause onRelease to be called twice, and another with a suggestion to simplify a boolean check for better readability. Overall, this is a high-quality contribution.
...ture/src/main/java/com/google/jetpackcamera/ui/components/capture/CaptureButtonComponents.kt
Show resolved
Hide resolved
Summary of ChangesThis pull request refines the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
|
b15fb8a to
1f5bccd
Compare
This also adds an additional interactionSource to the capture button so we can emulate touch events in our compose previews.
Also ensures the disabled state for the capture button has the correct animations for the nucleus.
Also animates to/from the pressed state
d9398ce to
647522b
Compare
This PR updates the appearance and behavior of the
CaptureButtoncomponent to better match design mocks and improve preview visibility.Key Changes
Behavioral Fixes:
VIDEO_ONLYmode: The nucleus is now white when idle and turns red only when pressed or recording (previously it was always red).IMAGE_ONLYmode.Refactoring:
CaptureButtonimplementation.