This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Open
Conversation
clmctfy/include/clmctfy.h
Outdated
Contributor
There was a problem hiding this comment.
Can we move the includes into "/includes"? I think the c bindings implementation is still okay to have where it is.
Author
|
I noticed that the parameter order does not follow the coding style (Should be input first then output). I will change them later. |
Author
|
Please take another look. Besides those lines mentioned in the reviews, I made the following changes as well:
|
Author
|
I just made a rebase onto 0.4.5. Please take another look. |
Contributor
|
Thanks. Ignore the travis error - its not fully setup. There's a jenkins build and test that should be firing up. |
|
Can one of the admins verify this patch? |
Contributor
|
ok to test |
|
All tests passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C binding for lmctfy.
lmctfy__raw. The_rawfunctions takes a serialized buffer to represent the protobuf generated object.::util::Statusor::util::StatusOrhas a corresponding function in the c library which takes astruct status *as its first parameter. The status structure will be used as output. Those functions will also check the error code in the status structure before executing other code in the functions. If the error code is not zero, they will return immediately with the error code.