This repository was archived by the owner on May 27, 2024. It is now read-only.
Open
Conversation
jeffbyrnes
suggested changes
Aug 19, 2019
Contributor
jeffbyrnes
left a comment
There was a problem hiding this comment.
The Dockerfile has a typo, and is missing the “r” in its name.
To fix:
git mv Dockefile Dockerfile
git add Dockerfile
git commit --amend
# Adjust commit message as-needed
git push --force origin masterand this PR will be updated without adding any additional commits, as if it was always named properly.
jeffbyrnes
approved these changes
Aug 26, 2019
Contributor
jeffbyrnes
left a comment
There was a problem hiding this comment.
Seems good! What are you thinking a CI/CD mechanism would do?
Author
either Google Cloud Build or Docker Hub build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the repository requires local builds, I thought that implementing a pipeline would be a nice feature.