fix: use correct default URL constant for netgroup_url #242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a copy-paste bug in
HttpFilesSource._SetDefaults()wherenetgroup_urlincorrectly defaults toGROUP_URLinstead ofNETGROUP_URL.The Bug
In
nss_cache/sources/httpsource.pyline 94, the default value fornetgroup_urlwas set toself.GROUP_URL:This is clearly a copy-paste error from the
group_urlhandling on line 91-92 directly above it.The Fix
Changed to use the correct constant
self.NETGROUP_URL:Impact
Without this fix, any netgroup lookups using the HTTP source that don't explicitly configure
netgroup_urlwould incorrectly use the group URL by default, leading to failed or incorrect netgroup resolution.