Skip to content

Enhance SpliceD logging for domain join failures #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 10, 2026
Merged

Enhance SpliceD logging for domain join failures #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shared/provisioning/provisioning_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func TextData(hostname, domain string, reuse, djoinCompat bool) ([]byte, error)
uintptr(unsafe.Pointer(&buff)), //_Out_opt_ LPWSTR *pProvisionTextData
)
if r != 0 {
return result, errnoErr(syscall.Errno(r))
return result, fmt.Errorf("%v: Win32 error %d", errnoErr(syscall.Errno(r)), r)
}

for i := range buff {
Expand Down Expand Up @@ -192,7 +192,7 @@ func BinData(hostname string, domain string, reuse bool) ([]byte, error) {
0, //_Out_opt_ LPWSTR *pProvisionTextData
)
if r != 0 {
return buff[:binSize], errnoErr(syscall.Errno(r))
return buff[:binSize], fmt.Errorf("%v: Win32 error %d", errnoErr(syscall.Errno(r)), r)
}

return buff[:binSize], nil
Expand Down
2 changes: 1 addition & 1 deletion spliced/spliced.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ func join(req *models.Request) ([]byte, error) {
metrics.Get("join_attempt").Increment()
blob, err := provisioner(wantName, conf.Domain, permitReuse(req))
if err != nil {
deck.WarningfA("Failed to join host with: %v", err).With(eventID(EvtJoinFailure)).Go()
deck.WarningfA("Failed to join host %s to domain %s (reuse=%t) with: %v", wantName, conf.Domain, permitReuse(req), err).With(eventID(EvtJoinFailure)).Go()
return nil, err
}

Expand Down
Loading