Skip to content

Add additional argument to _aten_bmm #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrplatin wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Add additional argument to _aten_bmm #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torchax/ops/jaten.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ def _aten_dist(input, other, p=2):


@op(torch.ops.aten.bmm)
def _aten_bmm(x, y):
def _aten_bmm(x, y, out=None):
Copy link
Collaborator

@wdhongtw wdhongtw Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an assertion to ensure the out is indeed None?

Copy link
Collaborator

@wdhongtw wdhongtw Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there is a helper class OutVariant (and a mapping _out_variant_to_functional), not sure if it can solve your problem.

res = x @ y
return res
# return jnp.einsum('bnm,bmk->bnk', x, y)
Expand Down
Loading