Skip to content

Add named arguments to the pywrap_profiler_plugin functions. #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add named arguments to the pywrap_profiler_plugin functions. #3452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions tsl/profiler/lib/profiler_session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,24 +65,36 @@ absl::Status ProfilerSession::Status() {
absl::Status ProfilerSession::CollectDataInternal(XSpace* space) {
absl::MutexLock l(mutex_);
TF_RETURN_IF_ERROR(status_);
LOG(INFO) << "Profiler session collecting data.";
LOG(INFO) << "[SERVER] ProfilerSession::CollectDataInternal started.";
if (profilers_ != nullptr) {
LOG(INFO) << "[SERVER] Stopping profiler collection.";
profilers_->Stop().IgnoreError();
stop_time_ns_ = profiler::GetCurrentTimeNanos();
LOG(INFO) << "[SERVER] Collecting data from profilers.";
profilers_->CollectData(space).IgnoreError();
profilers_.reset(); // data has been collected.
LOG(INFO) << "[SERVER] Finished collecting data from profilers.";
} else {
LOG(INFO) << "[SERVER] No active profilers to collect data from.";
}
// Allow another session to start.
profiler_lock_.ReleaseIfActive();
LOG(INFO) << "[SERVER] ProfilerSession::CollectDataInternal finished.";
return absl::OkStatus();
}
#endif

absl::Status ProfilerSession::CollectData(XSpace* space) {
#if !defined(IS_MOBILE_PLATFORM)
space->add_hostnames(port::Hostname());
std::string hostname = port::Hostname();
LOG(INFO) << "[SERVER] ProfilerSession::CollectData started for host: "
<< hostname;
space->add_hostnames(hostname);
TF_RETURN_IF_ERROR(CollectDataInternal(space));
LOG(INFO) << "[SERVER] Post-processing XSpace data for host: " << hostname;
profiler::PostProcessSingleHostXSpace(space, start_time_ns_, stop_time_ns_);
LOG(INFO) << "[SERVER] ProfilerSession::CollectData finished for host: "
<< hostname;
#endif
return absl::OkStatus();
}
Expand Down
Loading