Always run the name generators passed to TraceMe on debug builds to help catch bugs#3480
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 3, 2026
Merged
Always run the name generators passed to TraceMe on debug builds to help catch bugs#3480copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_863718821
branch
4 times, most recently
from
dd98595 to
5786685
Compare
…elp catch bugs Today, the name generators are run only when there is an active tracing session, which means that none of the code inside the name generators are tested at all. Since users sometimes perform non-trivial work (such as accessing pointers that may be dangling) inside the name generators, it is useful to test such code by always invoking the name generators in debug builds where the extra overhead is not a concern. PiperOrigin-RevId: 864742934
copybara-service
bot
force-pushed
the
test_863718821
branch
from
5786685 to
88f1a04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always run the name generators passed to TraceMe on debug builds to help catch bugs
Today, the name generators are run only when there is an active tracing session, which means that none of the code inside the name generators are tested at all. Since users sometimes perform non-trivial work (such as accessing pointers that may be dangling) inside the name generators, it is useful to test such code by always invoking the name generators in debug builds where the extra overhead is not a concern.