[TSL] Export protobuf includes in tsl/platform/protobuf.h#3488
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 11, 2026
Merged
[TSL] Export protobuf includes in tsl/platform/protobuf.h#3488copybara-service[bot] merged 1 commit intomainfrom
tsl/platform/protobuf.h#3488copybara-service[bot] merged 1 commit intomainfrom
Conversation
These includes are forwarding the content of header files to those that includes `tsl/platform/protobuf.h`. Thus, they should be marked using `export` rather than `keep`. This makes the user code of `tsl/platform/protobuf.h` not attempt to remove the include. PiperOrigin-RevId: 868804207
copybara-service
bot
force-pushed
the
test_868373810
branch
from
9baeaf4 to
d70fa0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[TSL] Export protobuf includes in
tsl/platform/protobuf.hThese includes are forwarding the content of header files to those that includes
tsl/platform/protobuf.h. Thus, they should be marked usingexportrather thankeep.This makes the user code of
tsl/platform/protobuf.hnot attempt to remove the include.