Mv fix regrid leak logging #202
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() to work properly with beam (for reasons I don't totally understand).
alxmrs
reviewed
Jul 20, 2022
Contributor
alxmrs
left a comment
alxmrs
left a comment
There was a problem hiding this comment.
Mostly nits. Thanks for your changes!
weather_mv/loader_pipeline/regrid.py
Outdated
Comment on lines
110
to
114
| logger.debug(f'Located temporary directories to remove: {cache_dir} [{file_regrid_label!r}].') | ||
| shutil.rmtree(cache_dir) | ||
| logger.debug(f'Temporary directories removed [{file_regrid_label!r}].') | ||
| os.makedirs(cache_dir) | ||
| logger.debug(f'Re-building empty temporary directory structure [{file_regrid_label!r}].') |
Contributor
There was a problem hiding this comment.
I think these are too many debug messages. Won't it pollute the logs?
Collaborator
Author
There was a problem hiding this comment.
Yea I'll thin them out after I determine whether we actually even need this code for clearing the temp directories.
Collaborator
Author
There was a problem hiding this comment.
I thinned them out, though this block may be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added extra logging.