Conversation
HamdaanAliQuatil
left a comment
There was a problem hiding this comment.
@bhushangitfull It looks like you've committed Python virtual environment files to the repository. Could you please remove the .venv directory so we can proceed with the review?
Also, could you please list the steps you took for this upgrade?
|
Sure, here are the steps. The update process consists of the following key steps: 1. Cleanup: 2. Fetch Latest Revision: 3. Copy BoringSSL: 4. Bump Revision: |
|
Let's do this in two PRs. (1) PR that lands a script for rolling a BoringSSL update. In practice, we probably need to have me or someone else trusted run (2), in an ideal world we can run it in Github Actions. It's simply impossible to even attempt to review this PR, and we absolutely can't a BoringSSL update without being able to prove that the files from BoringSSL have not been tampered with. Nothing personal, but I think everyone wants to be certain the files are copied over correctly :D |
No description provided.