This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Case sensitivity and descendant issue selecting to much or wrong thing.#48
Closed
nedjs wants to merge 11 commits intogoogle:masterfrom
Closed
Case sensitivity and descendant issue selecting to much or wrong thing.#48nedjs wants to merge 11 commits intogoogle:masterfrom
nedjs wants to merge 11 commits intogoogle:masterfrom
Conversation
…d names *:nodeName prefix:* *:* *
…ication(*) to fail. Fixed regex to only group asteriks when part of a name space definition(:)
Conflicts: src/lexer.js src/nameTest.js src/parser.js src/wgxpath.js
… case sensitive. - Fixed descendant issue where nodes were being selected when they shouldn’t have when using variations of "//". Caused by the "Test" not being invoked during recursive node matching when finding descendants.
- Fixed name() and local-name() also converting to lower case unnecessary
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! |
…ode.nodeName returns a case insensitive version of the nodes name where localName and prefix return case sensitive versions of the respective qname.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is in regards to a few issues brought up and is very similar to @Sebmaster pull request at #41 Namespaces are handled slightly wrong. Since its been a few months since sebmasters commit went up I figured I would put this one in.
Issues this fix addresses:
#46 wgxpath cannot evaluate upper case
#43 XML descendant problem
I did not commit any unit tests for this because I dont have any idea how to run them. It would probably be good to add a few for case sensitivity and for descendants.
Warning: I suck at git and my commits are a pile of garbage, IDK whats going on in there so i just merged master into it before I made the changes. I guess just ignore the rest.