This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Kind test matches text() to both parsed and not parsed character nodes.#55
Open
jonmaber wants to merge 1 commit intogoogle:masterfrom
Open
Kind test matches text() to both parsed and not parsed character nodes.#55jonmaber wants to merge 1 commit intogoogle:masterfrom
jonmaber wants to merge 1 commit intogoogle:masterfrom
Conversation
This is needed because, although CDATA_SECTION_NODE type is deprecated, popular browsers still use it. (They ought to convert incoming CDATA sections to TEXT_NODE.)
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Author
|
Closed because I don't have and don't want a google account and so I can't access and approve the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed because, although CDATA_SECTION_NODE type is deprecated,
popular browsers still use it when building DOM from xml files. (They ought to convert
incoming CDATA sections to TEXT_NODE but they don't.) At the same time the built in
evaluate function in Firefox, Chrome, Safari etc. return the right results by matching text()
to both types of node. wgxpath (and M.S. Edge) only match to TEXT_NODE type so
CDATA sections are treated as non-text.
Here is a jsfiddle that shows how wgxpath 1.3.0 gives unexpected results
https://jsfiddle.net/r73me5er/11/