Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Comments

Kind test matches text() to both parsed and not parsed character nodes.#55

Open
jonmaber wants to merge 1 commit intogoogle:masterfrom
jonmaber:master
Open

Kind test matches text() to both parsed and not parsed character nodes.#55
jonmaber wants to merge 1 commit intogoogle:masterfrom
jonmaber:master

Conversation

@jonmaber
Copy link

@jonmaber jonmaber commented May 6, 2018

This is needed because, although CDATA_SECTION_NODE type is deprecated,
popular browsers still use it when building DOM from xml files. (They ought to convert
incoming CDATA sections to TEXT_NODE but they don't.) At the same time the built in
evaluate function in Firefox, Chrome, Safari etc. return the right results by matching text()
to both types of node. wgxpath (and M.S. Edge) only match to TEXT_NODE type so
CDATA sections are treated as non-text.

Here is a jsfiddle that shows how wgxpath 1.3.0 gives unexpected results
https://jsfiddle.net/r73me5er/11/

This is needed because, although CDATA_SECTION_NODE type is deprecated,
popular browsers still use it. (They ought to convert incoming CDATA
sections to TEXT_NODE.)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jonmaber jonmaber closed this May 6, 2018
@jonmaber
Copy link
Author

jonmaber commented May 6, 2018

Closed because I don't have and don't want a google account and so I can't access and approve the CLA.

@jonmaber jonmaber reopened this May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants