Open
Conversation
amanda-tarafa
approved these changes
Jul 8, 2025
Contributor
amanda-tarafa
left a comment
amanda-tarafa
left a comment
There was a problem hiding this comment.
A couple of comments, but likely because I don't have enough context.
|
|
||
| - id: googleapis-test | ||
| name: gcr.io/gapic-images/googleapis:prod | ||
| entrypoint: "/workspace/tools/bazel-test.sh" |
Contributor
There was a problem hiding this comment.
I think?
Suggested change
| entrypoint: "/workspace/tools/bazel-test.sh" | |
| entrypoint: "/tools/bazel-test.sh" |
| @@ -0,0 +1,28 @@ | |||
| # Copyright 2025 Google LLC | |||
Contributor
There was a problem hiding this comment.
Does this need to be on the repo root? I don't mind that much but if it can be in a folder similar to the actions folder that'd be good, like .cloudbuild
| GAPIC_GENERATOR_COMMIT=$1 | ||
| if [[ -z "${GAPIC_GENERATOR_COMMIT}" ]] | ||
| then | ||
| echo "GAPIC_GENERATOR_COMMIT not set, trying default" |
Contributor
There was a problem hiding this comment.
Suggested change
| echo "GAPIC_GENERATOR_COMMIT not set, trying default" | |
| echo "GAPIC_GENERATOR_COMMIT not set" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This presubmit should help us be confident that it will run against googleapis/googleapis when we try to update the generator version.