chore: Migrate gsutil usage to gcloud storage#942
chore: Migrate gsutil usage to gcloud storage#942gurusai-voleti wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
Hi @chris, Can we get your review on this PR? Thanks! |
Summary of ChangesHello @gurusai-voleti, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is part of an ongoing automated initiative to transition from the legacy Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request appears to combine two separate changes: an automated migration from gsutil to gcloud storage and the addition of a new Python script to identify top repository contributors. For better traceability and easier reviews, it's recommended to submit these as separate pull requests.
My review focuses on the code changes themselves. The migration in discovery.json has introduced a syntax error that makes the JSON file invalid, which I've flagged as critical. The new main.py script is functional, but I've suggested a couple of improvements for exception handling and code readability.
| "Unspecified defaults to GSUTIL.", | ||
| "Use the \"gsutil\" tool to download the source file.", | ||
| "Use the Cloud Storage Fetcher tool to download the source file." | ||
| "Use the \"gcloud storage\" tool to download the source file.", "Use the Cloud Storage Fetcher tool to download the source file." |
There was a problem hiding this comment.
| except Exception: | ||
| return default_handle |
There was a problem hiding this comment.
The except Exception: is too broad and will silently swallow any error, which can make debugging difficult. If the goal is to make the script robust against any failure, it would be better to at least log the exception to provide visibility into what went wrong. For example, you could print the error to sys.stderr. You'll need to import sys at the top of the file for this suggestion to work.
| except Exception: | |
| return default_handle | |
| except Exception as e: | |
| print(f"Warning: Failed to fetch GitHub username for {email}. Error: {e}", file=sys.stderr) | |
| return default_handle |
| # Reviewers list remains empty as per requirement | ||
| reviewers_list = [] | ||
|
|
||
| key_string = f"f'{_PROJECTS_DIR}/{_REPO_NAME}/{folder}/*'" |
There was a problem hiding this comment.
The way key_string is constructed using a nested f-string (f"f'...'") is a bit confusing. The outer f-string creates a string that is itself an f-string literal. This will be evaluated to a regular string when used as a dictionary key, so the f prefix is redundant. You can simplify this for better readability.
| key_string = f"f'{_PROJECTS_DIR}/{_REPO_NAME}/{folder}/*'" | |
| key_string = f"'{_PROJECTS_DIR}/{_REPO_NAME}/{folder}/*'" |
Automated: Migrate {target_path} from gsutil to gcloud storage
This CL is part of the on going effort to migrate from the legacy
gsutiltool to the new and improvedgcloud storagecommand-line interface.gcloud storageis the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with othergcloudcomponents. 🚀Automation Details
This change was generated automatically by an agent that targets users of
gsutil.The transformations applied are based on the gsutil to gcloud storage migration guide.
While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between
gsutilandgcloud storagethat could impact your workflows.For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the
gcloud storage rsynccommand has a different file deletion logic thangsutil rsync, which could lead to unintended file deletions.Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.
Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.
Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.
Support and Collaboration
The
GCS CLIteam is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.We are happy to work with you to test and adjust these changes as needed.
Contact:
gcs-cli-hyd@google.comWe appreciate your partnership in this important migration effort!
#gsutil-migration