Skip to content

chore: Migrate gsutil usage to gcloud storage#942

Closed
gurusai-voleti wants to merge 1 commit intogoogleapis:mainfrom
gurusai-voleti:ai-gsutil-migration-a597aaa8519e4706b3f86dffc58a9558
Closed

chore: Migrate gsutil usage to gcloud storage#942
gurusai-voleti wants to merge 1 commit intogoogleapis:mainfrom
gurusai-voleti:ai-gsutil-migration-a597aaa8519e4706b3f86dffc58a9558

Conversation

@gurusai-voleti
Copy link

Automated: Migrate {target_path} from gsutil to gcloud storage

This CL is part of the on going effort to migrate from the legacy gsutil tool to the new and improved gcloud storage command-line interface.
gcloud storage is the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with other gcloud components. 🚀

Automation Details

This change was generated automatically by an agent that targets users of gsutil.
The transformations applied are based on the gsutil to gcloud storage migration guide.

⚠️ Action Required: Please Review and Test Carefully

While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between gsutil and gcloud storage that could impact your workflows.
For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the gcloud storage rsync command has a different file deletion logic than gsutil rsync, which could lead to unintended file deletions.

Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.

Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.

Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.

Support and Collaboration

The GCS CLI team is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.
We are happy to work with you to test and adjust these changes as needed.

Contact: gcs-cli-hyd@google.com

We appreciate your partnership in this important migration effort!

#gsutil-migration

@gurusai-voleti gurusai-voleti requested a review from a team as a code owner February 2, 2026 15:11
@gurusai-voleti
Copy link
Author

Hi @chris, Can we get your review on this PR? Thanks!

@gemini-code-assist
Copy link

Summary of Changes

Hello @gurusai-voleti, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is part of an ongoing automated initiative to transition from the legacy gsutil tool to the modern gcloud storage command-line interface. It includes a direct update to a discovery.json file to reflect this migration. Additionally, a new Python script (main.py) has been introduced, which appears to be a utility for identifying and listing top human contributors in a repository, likely to assist in managing the review and ownership of these automated migration changes.

Highlights

  • Migration to gcloud storage: The discovery.json file has been updated to reflect the use of gcloud storage instead of gsutil for downloading source files, aligning with the ongoing migration effort.
  • New Contributor Analysis Script: A new Python script, main.py, has been added. This script is designed to identify top non-bot contributors in a given directory, fetch their GitHub usernames, and generate configuration based on this analysis. This likely supports the automated migration effort by helping to identify relevant human stakeholders for review or ownership.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to combine two separate changes: an automated migration from gsutil to gcloud storage and the addition of a new Python script to identify top repository contributors. For better traceability and easier reviews, it's recommended to submit these as separate pull requests.

My review focuses on the code changes themselves. The migration in discovery.json has introduced a syntax error that makes the JSON file invalid, which I've flagged as critical. The new main.py script is functional, but I've suggested a couple of improvements for exception handling and code readability.

"Unspecified defaults to GSUTIL.",
"Use the \"gsutil\" tool to download the source file.",
"Use the Cloud Storage Fetcher tool to download the source file."
"Use the \"gcloud storage\" tool to download the source file.", "Use the Cloud Storage Fetcher tool to download the source file."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The automated migration has introduced a syntax error, merging two array elements onto a single line without a proper comma separator. This makes the JSON file invalid.

      "Use the \"gcloud storage\" tool to download the source file.",
      "Use the Cloud Storage Fetcher tool to download the source file."

Comment on lines +50 to +51
except Exception:
return default_handle

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The except Exception: is too broad and will silently swallow any error, which can make debugging difficult. If the goal is to make the script robust against any failure, it would be better to at least log the exception to provide visibility into what went wrong. For example, you could print the error to sys.stderr. You'll need to import sys at the top of the file for this suggestion to work.

Suggested change
except Exception:
return default_handle
except Exception as e:
print(f"Warning: Failed to fetch GitHub username for {email}. Error: {e}", file=sys.stderr)
return default_handle

# Reviewers list remains empty as per requirement
reviewers_list = []

key_string = f"f'{_PROJECTS_DIR}/{_REPO_NAME}/{folder}/*'"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The way key_string is constructed using a nested f-string (f"f'...'") is a bit confusing. The outer f-string creates a string that is itself an f-string literal. This will be evaluated to a regular string when used as a dictionary key, so the f prefix is redundant. You can simplify this for better readability.

Suggested change
key_string = f"f'{_PROJECTS_DIR}/{_REPO_NAME}/{folder}/*'"
key_string = f"'{_PROJECTS_DIR}/{_REPO_NAME}/{folder}/*'"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant