Add composer.json support for psr/cache v3#390
Closed
pbowyer wants to merge 1 commit intogoogleapis:mainfrom
Closed
Add composer.json support for psr/cache v3#390pbowyer wants to merge 1 commit intogoogleapis:mainfrom
pbowyer wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Author
|
I've clicked the "rescan pull request" link after signing the CLA, submitted the form and... nothing 🤷♂️ |
Contributor
|
This is being handled more robustly in #364 Please try using this branch by requiring it as an alias in composer.json and let me know if it works as you expect it to: |
Contributor
|
This is now released in v1.20.0 |
Author
|
Thanks, tested and confirmed working 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue I reported at googleapis/google-cloud-php#5205.
When using PHP 8.1 it's becoming common to have packages that require
psr/cache:^3(in my case:symfony/cache-contracts:v3.0.0).google/auth:v1.19.0still requirespsr/cache ^1.0|^2.0. This is preventing me from installing google/cloud-vision.The only change with
psr/cache:^3.0is adding return types for PHP 8.0+, so you can support it as an option as it does not introduce any other changes.