-
Notifications
You must be signed in to change notification settings - Fork 98
impl(storage): add conformance test fixtures #4133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl(storage): add conformance test fixtures #4133
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4133 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 183 183
Lines 6915 6922 +7
=======================================
+ Hits 6550 6557 +7
Misses 365 365 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/storage/src/storage/conformance/test_service_account.not-a-test.json
Show resolved
Hide resolved
alvarowolfx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sent a commit addressing the points raised
Add GCS conformance tests files, rust structs to read such files and base unit tests to run such tests.
Towards #3645