Skip to content

fix(auth): force minimum version for aws-lc-rs #4387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coryan merged 1 commit into from
Jan 26, 2026
Merged

fix(auth): force minimum version for aws-lc-rs #4387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ http-body = { default-features = false, version = "1" }
http-body-util = { default-features = false, version = "0.1.3" }
humantime = { default-features = false, version = "2" }
hyper = { default-features = false, version = "1" }
jsonwebtoken = { default-features = false, version = "10" }
jsonwebtoken = { default-features = false, version = "10.2" }
lazy_static = { default-features = false, version = "1.2" }
opentelemetry = { default-features = false, version = "0.31", features = ["trace"] }
opentelemetry-proto = { default-features = false, version = "0.31", features = ["gen-tonic", "trace"] }
Expand Down Expand Up @@ -371,8 +371,11 @@ opentelemetry-semantic-conventions = { default-features = false, version = "0.31
] }


# Transitive dependencies. Used for minimal version selection.
mime = { default-features = false, version = "0.3.17" }
# Some of our direct dependencies fail to declare the minimum version
# requirements correctly. Force a higher version so we can test our own minimum
# version requirements in the minimal-versions build.
mime = { default-features = false, version = "0.3.17" }
aws-lc-rs = { default-features = false, version = "1.15.4" }

# Test packages
anyhow = { default-features = false, version = "1.0.100", features = ["std"] }
Expand Down
5 changes: 4 additions & 1 deletion src/auth/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ thiserror.workspace = true
time = { workspace = true, features = ["serde"] }
tokio = { workspace = true, features = ["fs", "process"] }
jsonwebtoken = { workspace = true, optional = true }
# We do not use this directly, but without it the minimal-versions build breaks.
# See: https://github.com/Keats/jsonwebtoken/pull/481
aws-lc-rs = { workspace = true, optional = true }
# Local dependencies
gax.workspace = true

Expand Down Expand Up @@ -74,7 +77,7 @@ idtoken = ["dep:jsonwebtoken"]
# link `google-cloud-auth` with `default-features = false, features = ["idtoken"]
# and then directly configure the `jsonwebtoken` features to select the
# `rust_crypto` backend.
default-idtoken-backend = ["jsonwebtoken?/aws_lc_rs"]
default-idtoken-backend = ["dep:aws-lc-rs", "jsonwebtoken?/aws_lc_rs"]
# Enabled by default. Use the default rustls crypto provider ([aws-lc-rs]) for
# TLS and authentication. Applications with specific requirements for
# cryptography (such as exclusively using the [ring] crate) should disable this
Expand Down
Loading