Skip to content

Comments

fix: only apply empty commits to all libraries if they have the release-as key word#2683

Open
ldetmer wants to merge 3 commits intomainfrom
fix-empty
Open

fix: only apply empty commits to all libraries if they have the release-as key word#2683
ldetmer wants to merge 3 commits intomainfrom
fix-empty

Conversation

@ldetmer
Copy link
Contributor

@ldetmer ldetmer commented Feb 20, 2026

google-cloud-node has a commit that randomly shows up as empty (I literally have witnessed this in the github gui). When this happens we apply it to all libraries. This is an intermittent issue. However we should only apply empty commits to all libraries if its a specific commit for the release-as functionality.

@ldetmer ldetmer requested review from a team as code owners February 20, 2026 14:17
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 20, 2026
if (
commit.files.length === 0 &&
this.includeEmpty &&
commit.message.includes('release-as')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be case-agnostic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants