fix: preserve version in merge plugin when no root candidate exists#2687
Open
seven332 wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: preserve version in merge plugin when no root candidate exists#2687seven332 wants to merge 1 commit intogoogleapis:mainfrom
seven332 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
When all packages live in subdirectories (no package at path '.'), the Merge plugin failed to set the version field on the merged pull request. This caused downstream workspace plugins to drop the merged candidate because they filter out candidates without a version. This is a problem in polyglot monorepos that use multiple workspace plugins (e.g. node-workspace + cargo-workspace): the second plugin's run() method drops the first plugin's merged result due to missing version. Fix: fall back to the first in-scope candidate when there is no root-path candidate, and always propagate the version field to the merged pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When all packages live in subdirectories (no package at path '.'), the Merge plugin failed to set the version field on the merged pull request. This caused downstream workspace plugins to drop the merged candidate because they filter out candidates without a version.
This is a problem in polyglot monorepos that use multiple workspace plugins (e.g. node-workspace + cargo-workspace): the second plugin's run() method drops the first plugin's merged result due to missing version.
Fix: fall back to the first in-scope candidate when there is no root-path candidate, and always propagate the version field to the merged pull request.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2686 🦕