Ignore matches with deactivated tickets#22
Open
janpantel wants to merge 1 commit intogoogleforgames:mainfrom
Open
Ignore matches with deactivated tickets#22janpantel wants to merge 1 commit intogoogleforgames:mainfrom
janpantel wants to merge 1 commit intogoogleforgames:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an option to automatically drop matches made by a MMF in case tickets were deactivated while the MMF was working.
A real world use case for this would be when the user decides to stop queueing for a match while we are in the process making a match for them. Right now it forces developers to retain a certain amount of state in a non authoritative ticket producer. While this change doesn't fully resolve the race condition, it lowers the likelihood to a (probably) acceptable level.
I've covered the feature with a feature flag to not make it a breaking change.