Skip to content

chore: update README per template#38

Open
wescpy wants to merge 2 commits intogh-pagesfrom
wescpy
Open

chore: update README per template#38
wescpy wants to merge 2 commits intogh-pagesfrom
wescpy

Conversation

@wescpy
Copy link

@wescpy wescpy commented Dec 12, 2024

chore: update README per template

@wescpy wescpy requested a review from wangela December 12, 2024 08:45
@wescpy wescpy changed the title fix: update README per template chore: update README per template Dec 13, 2024
@wescpy wescpy requested a review from jeff-bowman January 10, 2025 00:13
@wescpy wescpy marked this pull request as ready for review March 1, 2025 22:14
@wescpy
Copy link
Author

wescpy commented Mar 1, 2025

Currently this repo (url-signing) doesn't have a LICENSE, CONTRIBUTING.md, nor CODE_OF_CONDUCT.me, and the README doesn't say either way whether external PRs are accepted or not. The Google Legal-approved "Support" section points to CONTRIBUTING.md, so one s/b added either way.


## Contributing

External contributions are not (yet) accepted for this repository. See [contributing guide] for more info.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with note that we should add contributors guide, license, and code of conduct. I don't know whether we should proceed with this PR if they 404. Will discuss in chat.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. You & Angela need to make a call on what to do with this repo before we proceed. Since every other repo has these 3 core documents, the fact they're missing here suggests it may be deliberate. Otherwise it was pulled together extremely quickly without much thought of "compliance" and consistency with the other repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants