Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a runtime error in the validator’s weight/telemetry delta processing by consistently using the WeightsManager’s PlatformManager instance when extracting per-platform metrics and iterating platform configs.
Changes:
- Use
self.platform_manager(instance member) instead of an undefinedplatform_managerreference when extracting platform metrics. - Use
self.platform_managerwhen iterating all platform configs to compute dynamic error totals.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical bug in weight setting where
platform_managerwas referenced withoutself., causing aNameErrorand preventing weights from being set.Error seen in production:
Changes
platform_manager.extract_platform_metrics_from_stats()→self.platform_manager.extract_platform_metrics_from_stats()(line 355)platform_manager.get_all_platforms()→self.platform_manager.get_all_platforms()(line 384)Test plan