Conversation
There was a problem hiding this comment.
Pull request overview
This PR keeps external MASA TEE worker registry state in sync with the validator by removing TEE worker entries when a miner deregisters, and cleans up a platform manager reference in weight calculation.
Changes:
- Fix
_get_delta_node_datato consistently useself.platform_manager. - On miner deregistration, call the MASA TEE API to remove each associated TEE worker address.
- Add a new async helper
_remove_tee_worker_from_api(and related imports/logging) to perform the API call.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
validator/weights.py |
Uses self.platform_manager for platform metric extraction and platform enumeration during delta calculation. |
validator/node_manager.py |
Adds MASA API deregistration calls during disconnected-node cleanup via a new aiohttp-based helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Remove unused List import from typing - Use _ for unused worker_id in loop Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Switch from aiohttp to existing http_client_manager (httpx) - Removes new dependency, reuses connection pool - Re-raise CancelledError for clean shutdown Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
platform_manager→self.platform_managerreferences in_get_delta_node_datathat were causingNameErrorduring weight calculationTest plan
python -m py_compile)