feat: optimize process #1355

hwbrzzl · 2026-01-20T03:58:06Z

📑 Description

It's complicated to check result and error simultaneously.

res, err := facades.Process().Run()
if err != nil {}
if res.Failed {}
if res.ErrorOutput() != "" {}

After the optimization, it will be simpler:

res := facades.Process().Run()
if res.Failed {
  return res.Error()
}

Add a new WithSpinner function to show a spinner when running, and the message can be customized.

Use the default message:

Use the custom message:

Boot base service providers after all service providers are registered.
The pipeline should be broken when a command fails.
Add a new file.Copy() function.

✅ Checks

Added test cases for my code

gemini-code-assist · 2026-01-20T03:58:34Z

Summary of Changes

Hello @hwbrzzl, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors and enhances the process execution capabilities, making them more user-friendly and robust. It streamlines the Run method's error handling, introduces visual feedback with loading spinners for long-running tasks, and improves database initialization logic. Additionally, a new file utility function has been added for common file operations.

Highlights

Process Execution Simplification: The Process.Run method no longer returns an error directly, instead encapsulating error details within the Result object for a cleaner API.
Interactive Loading Spinners: A new WithLoading method has been added to the Process interface, allowing for the display of terminal loading spinners during command execution to provide better user feedback.
Robust Database Configuration: The GORM driver now gracefully handles cases where database host configurations are empty, preventing unnecessary errors.
File Copy Utility: A new Copy function has been introduced in the support/file package, providing a straightforward way to duplicate files.
Improved Process Result Reporting: The Result object's Successful(), Failed(), and Error() methods have been enhanced to provide more comprehensive status and error details, including stderr output.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces optimizations and new features to the process package, notably adding a loading spinner for running processes. It also refactors the Run method to encapsulate errors within the Result object, simplifying its signature. Additionally, a file copy utility is added.

My review focuses on a few critical issues that could lead to panics or incorrect behavior, such as a potential nil pointer dereference and inconsistent error handling. I've also provided suggestions to improve the robustness of a new file utility and its corresponding test. Overall, the changes are a good step forward, and the identified critical issues should be addressed.

process/process.go

process/result.go

database/driver/gorm.go

contracts/process/process.go

support/file/file.go

support/file/file_test.go

hwbrzzl · 2026-01-20T07:25:15Z

foundation/application.go

 	baseProviders := app.getBaseServiceProviders()
 	app.providerRepository.Add(baseProviders)
 	app.providerRepository.Register(app)
-	app.providerRepository.Boot(app)


Boot base service providers after all service providers are registered.

hwbrzzl · 2026-01-20T07:59:24Z

process/running_pipe.go

+				}

-		exitCode := getExitCode(finalCmd, waitErr)
+				break


The pipeline should be broken if a command failed.

codecov · 2026-01-20T08:48:01Z

Codecov Report

❌ Patch coverage is 90.72848% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.60%. Comparing base (13690b9) to head (fb996fa).
⚠️ Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
process/running.go	87.50%	2 Missing and 2 partials ⚠️
support/file/file.go	71.42%	2 Missing and 2 partials ⚠️
process/running_pipe.go	91.66%	1 Missing and 2 partials ⚠️
process/running_pool.go	88.88%	1 Missing and 1 partial ⚠️
process/result.go	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1355      +/-   ##
==========================================
+ Coverage   70.15%   70.60%   +0.45%     
==========================================
  Files         281      286       +5     
  Lines       17180    17612     +432     
==========================================
+ Hits        12052    12435     +383     
- Misses       4614     4652      +38     
- Partials      514      525      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

process/process.go

hwbrzzl · 2026-01-20T10:43:44Z

/gemini review

gemini-code-assist

Code Review

This is an excellent pull request that significantly improves the ergonomics and functionality of the process package. The change to the Run() method signature, encapsulating errors within the Result object, simplifies the API for consumers. The new WithSpinner feature is a great UX enhancement for long-running commands. Furthermore, the fixes addressing pipeline interruption on failure and the race condition in the process pool are crucial for correctness and robustness. The new file.Copy utility is also a welcome addition. The code is well-structured, and the changes are well-tested. I've included a few minor suggestions to enhance consistency in testing and error handling.

process/result_test.go

process/pipeline_windows_test.go

process/result.go

krishankumar01

Just a few suggestions

support/file/file.go

krishankumar01 · 2026-01-20T17:52:39Z

process/pool.go


 	var resultsWg sync.WaitGroup
 	var workersWg sync.WaitGroup
+	var startsWg sync.WaitGroup


I think this looks good, but when I checked start method again, I noticed a major issue. Even if we set a concurrency limit, it still spawns all the processes. So we might need to change the RunningPool implementation. We can optimize this in a different PR.

Example:

builder := NewPool().Concurrency(1) start := time.Now() rp, err := builder.Pool(func(p contractsprocess.Pool) { p.Command("sleep", "1").As("job1") p.Command("sleep", "1").As("job2") }).Start() assert.NoError(t, err) // ideally this should take more than 2 second but it will finish in ~1sec

krishankumar01 · 2026-01-20T17:57:23Z

process/pool.go

 func (r *PoolBuilder) Run() (map[string]contractsprocess.Result, error) {
-	return r.run(r.poolConfigurer)
+	run, err := r.start(r.poolConfigurer)
+	if err != nil {


Do we need to follow a similar syntax here? That is, should we return an error as part of RunningPool, even though the error might be more contextual or related to just process start?

Yes, I also considered this. But given it's map[string]contractsprocess.Result, it's a bit strange to initiate the map when error != nil. So I kept the error here.

process/result.go

process/running_pipe.go

process/running_pool.go

process/running_pool_unix_test.go

hwbrzzl · 2026-01-21T10:31:51Z

@krishankumar01 Thanks for your review, done. PTAL.

krishankumar01

Great 👍 LGTM

feat: optimize process

a848398

gemini-code-assist bot reviewed Jan 20, 2026

View reviewed changes

optimize

1d308cb

hwbrzzl commented Jan 20, 2026

View reviewed changes

hwbrzzl added 2 commits January 20, 2026 16:30

optimize

b42269c

optimize

d36429b

krishankumar01 reviewed Jan 20, 2026

View reviewed changes

process/process.go Outdated Show resolved Hide resolved

optimize

bc7f210

hwbrzzl marked this pull request as ready for review January 20, 2026 10:43

hwbrzzl requested a review from a team as a code owner January 20, 2026 10:43

hwbrzzl added the 🚀 Review Ready label Jan 20, 2026

hwbrzzl requested a review from krishankumar01 January 20, 2026 10:43

gemini-code-assist bot reviewed Jan 20, 2026

View reviewed changes

process/result_test.go Show resolved Hide resolved

process/pipeline_windows_test.go Outdated Show resolved Hide resolved

process/result.go Outdated Show resolved Hide resolved

hwbrzzl added 6 commits January 20, 2026 21:20

optimize

74e3c76

optimize

a92f0cf

optimize

0616c82

optimize

8018e5c

optimize

a695dc4

optimize

af40c81

krishankumar01 reviewed Jan 20, 2026

View reviewed changes

address comments

279fa1a

hwbrzzl requested a review from krishankumar01 January 21, 2026 10:31

krishankumar01 previously approved these changes Jan 21, 2026

View reviewed changes

fix lint

fb996fa

hwbrzzl dismissed krishankumar01’s stale review via fb996fa January 21, 2026 11:20

hwbrzzl merged commit 632170c into master Jan 21, 2026
20 of 21 checks passed

hwbrzzl deleted the bowen/optimize-process branch January 21, 2026 11:42

feat: optimize process #1355

feat: optimize process #1355

Conversation

hwbrzzl commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

✅ Checks

Uh oh!

gemini-code-assist bot commented Jan 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hwbrzzl Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

hwbrzzl commented Jan 20, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krishankumar01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

krishankumar01 Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

krishankumar01 Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hwbrzzl commented Jan 21, 2026

Uh oh!

krishankumar01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hwbrzzl commented Jan 20, 2026 •

edited

Loading

codecov bot commented Jan 20, 2026 •

edited

Loading