feat: add tabStyle to bubble preset#66
Open
Stringsaeed wants to merge 2 commits intogorhom:masterfrom
Open
Conversation
gorhom
requested changes
Jul 26, 2020
Owner
gorhom
left a comment
gorhom
left a comment
There was a problem hiding this comment.
also , you will need to add tabStyle docs into docs/bubble-preset.md.
gorhom
requested changes
Jul 28, 2020
Owner
gorhom
left a comment
gorhom
left a comment
There was a problem hiding this comment.
hi @Stringsaeed, thanks for updating this pr, however i left one comment regarding the description of the prop
also i think we should add tabStyle docs into docs/bubble-preset.md.
| export interface BubbleTabBarConfig {} | ||
| export interface BubbleTabBarConfig { | ||
| /** | ||
| * description |
Owner
There was a problem hiding this comment.
could you replace description with a description of the prop
|
It would be great to see this merged. It looks like the only outstanding issue is the documentation. @Stringsaeed are you able to make that change? If not, I can create a separate PR off of your branch which adds it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #65