Skip to content

[Review] [CDX-379] Validate testCells#1

Open
govambam wants to merge 1 commit intobase-for-pr-429from
review-pr-429
Open

[Review] [CDX-379] Validate testCells#1
govambam wants to merge 1 commit intobase-for-pr-429from
review-pr-429

Conversation

@govambam
Copy link
Owner

Recreated from Constructor-io#429 for Macroscope review.

Original PR: Constructor-io#429 by @esezen
Status: open (open)

Recreated using direct PR head fetch - exact current state preserved.

Original PR: Constructor-io#429

@macroscopeapp
Copy link

macroscopeapp bot commented Feb 11, 2026

Validate testCells by enforcing non-empty string values in ConstructorIO.constructor and ConstructorIO.setClientOptions using utils.helpers.toValidTestCells in constructorio.js

Introduce utils.helpers.toValidTestCells and apply it to testCells during construction and client option updates; add tests across constructor, modules, and utils to verify filtering and request parameter inclusion.

🖇️ Linked Issues

Resolves CDX-379 by validating testCells values during initialization, updates, and request construction.

📍Where to Start

Start with toValidTestCells in helpers.js, then review its usage in ConstructorIO.constructor and ConstructorIO.setClientOptions in constructorio.js.


Macroscope summarized 9833c5d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant