Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--ptf#466--ptf#466 How to integrate point-feature option in the standard workflow ? #339 -ptf option - recommended input & implementation details? #330There are at least two open tasks that remain to make this feature fully functional @gpertea .
Can you please look into the following and maybe add a commit to this PR? Would be fantastic.
Open Task 1: there is currently no parameter to control the usage of point features, i.e. a tolerance in bp until a PTF is used or not
Open Task 2: I could absolutely not find out why point features that exceed the transcript boundary even by just 1 bp are ignored?! The answer must be hidden in the 20,000 lines
rlink.cppfile. The sheer size and convolution of this code base is unfortunately too difficult to handle. I tried to comment out some of the filters but had no success.The point features can be tested using the test data like this:
where
long_reads_ptf.tsvis a TSV table like: