Support for multi bucket study loading and sheet integration in segmentation mode.#2
Open
Adithyan-Dinesh-Trenser wants to merge 23 commits intogradienthealth/Segmentation-with-DicomJSONfrom
Conversation
Ouwen
reviewed
Jan 2, 2024
| const study = findStudies('StudyInstanceUID', StudyInstanceUID)[0]; | ||
| let study = findStudies('StudyInstanceUID', StudyInstanceUID)[0]; | ||
|
|
||
| if (!study && buckets) { |
Member
There was a problem hiding this comment.
add a comment here
// if the study is not found but we have additional buckets, initialize the other bucket to try and retrieve the study.
Member
There was a problem hiding this comment.
actually, would this still be triggered since we initialize and store all the metadata?
Ouwen
reviewed
Jan 2, 2024
| ); | ||
| const imageIds = study.series | ||
| .filter( | ||
| (serie) => !segSOPClassUIDs.includes(serie.instances[0].SOPClassUID) |
Member
There was a problem hiding this comment.
I see are we only caching non segmentation files?
…itched with form panel. Implemented caching of segmentation files and loading of current study segmentations.
Adithyan-Dinesh-Trenser
force-pushed
the
gradienthealth/segmentation_mode_sheet_integration
branch
from
60dbf4c to
5c3fea4
Compare
…s it have different params for it. And blocked automatic segmentations loading in other than segmentation mode.
Adithyan-Dinesh-Trenser
force-pushed
the
gradienthealth/segmentation_mode_sheet_integration
branch
from
9f74aec to
1627f27
Compare
…mentation loading when another series in the study is loaded.
…entation label naming.
…ntation and loaded image mismatch when loading a study issue.
…ty and ViewPosition if available
…es. Added logic to use existing url to save segmentation file if available.
…nd modified the auto name generated when creating new segmentation.
…, this change is redundant and thus reverting.
maya-mohan
force-pushed
the
gradienthealth/segmentation_mode_sheet_integration
branch
from
69125ce to
fcaf0da
Compare
…e-sizing-not-working-in-Hologic-images fix: Fixed the issue of image sizing not working for Hologic images
…g_on_stack_viewport Correct the orientation by auto flipping when segmentation is auto loaded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.