Skip to content

Comments

fix(release-please): fix footer not appearing on release PRs#40

Merged
zeitlinger merged 1 commit intomainfrom
fix/release-please-footer-workaround
Feb 20, 2026
Merged

fix(release-please): fix footer not appearing on release PRs#40
zeitlinger merged 1 commit intomainfrom
fix/release-please-footer-workaround

Conversation

@zeitlinger
Copy link
Member

Summary

  • pull-request-footer was not being applied to release PRs because
    release-please defaults separatePullRequests to true for
    single-package configs, which skips the Merge plugin responsible for
    applying the footer
  • Setting separate-pull-requests: false forces the Merge plugin to run

Context

Test plan

  • After merging, verify the next release PR includes the footer

Release-please defaults `separatePullRequests` to `true` for
single-package configs, which skips the Merge plugin that applies
the configured `pull-request-footer`. Setting `separate-pull-requests`
to `false` explicitly forces the Merge plugin to run.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Copilot AI review requested due to automatic review settings February 20, 2026 16:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Release Please configuration so the pull-request-footer is applied to release PRs by ensuring the Merge plugin runs even in a single-package setup.

Changes:

  • Set separate-pull-requests: false in the Release Please config to force the Merge plugin to run.
  • Restores expected behavior where pull-request-footer appears on release PRs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zeitlinger
Copy link
Member Author

Upstream fix: googleapis/release-please#2685

@zeitlinger zeitlinger changed the title ci(release-please): fix footer not appearing on release PRs fix(release-please): fix footer not appearing on release PRs Feb 20, 2026
@zeitlinger zeitlinger merged commit d7a55e4 into main Feb 20, 2026
14 checks passed
@zeitlinger zeitlinger deleted the fix/release-please-footer-workaround branch February 20, 2026 17:09
zeitlinger added a commit that referenced this pull request Feb 20, 2026
…around (#42)

## Summary
- Remove `separate-pull-requests: false` added in #40
- That workaround is only needed for Java snapshot PRs (upstream bug:
  googleapis/release-please#2685)
- Flint uses `release-type: simple`, so the footer works without it

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
zeitlinger pushed a commit that referenced this pull request Feb 23, 2026
🤖 I have created a release *beep* *boop*
---


## [0.7.0](v0.6.0...v0.7.0)
(2026-02-23)


### Features

* handle line-number anchors and issue comments globally
([#56](#56))
([cf751df](cf751df))


### Bug Fixes

* **release-please:** fix footer not appearing on release PRs
([#40](#40))
([d7a55e4](d7a55e4))
* use remap instead of exclude for issue comment anchors
([#58](#58))
([656f355](656f355))

---
> [!IMPORTANT]
> Close and reopen this PR to trigger CI checks.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant