Protect map with a mutex#1
Open
dsymonds wants to merge 1 commit intograhamking:masterfrom
dsymonds:master
Open
Protect map with a mutex#1dsymonds wants to merge 1 commit intograhamking:masterfrom dsymonds:master
dsymonds wants to merge 1 commit intograhamking:masterfrom
dsymonds:master
Conversation
Go maps are not safe to mutate concurrent with other mutations or reads.
Owner
|
Thanks! None of the version are thread safe, and I agree they should be. My tests never used more than one thread, so performance results shouldn't change. I'll merge this when I do the other two versions. |
|
Hah, you beat me to it. Here's another approach that wraps the cache map in a thread-safe container: https://github.com/jbarham/Key-Value-Polyglot/blob/master/memg.go |
tbowling89
approved these changes
Dec 15, 2020
tbowling89
approved these changes
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go maps are not safe to mutate concurrent with other mutations or reads.