Skip to content

add freq option to histogram#289

Closed
eleuven wants to merge 2 commits intograntmcdermott:mainfrom
eleuven:freq-option
Closed

add freq option to histogram#289
eleuven wants to merge 2 commits intograntmcdermott:mainfrom
eleuven:freq-option

Conversation

@eleuven
Copy link
Contributor

@eleuven eleuven commented Jan 23, 2025

title says it all...

@grantmcdermott
Copy link
Owner

Thanks, will look at this once we get a few of the other PRs in the queue merged.

@grantmcdermott
Copy link
Owner

Thanks for this @eleuven.

Looking over your code here reminds me that the ylab logic is a little convoluted and could have been simplified as part of our new type system refactor. Let me take a stab at doing this in a separate PR and also role in some additional histogram arguments (which would avoid having to resolve some annoying merge conflicts in the GitHub UI from our previous PR).

@grantmcdermott
Copy link
Owner

Closing in favour of #296

@eleuven
Copy link
Contributor Author

eleuven commented Feb 3, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants