Closed
Conversation
Owner
|
Thanks, will look at this once we get a few of the other PRs in the queue merged. |
Owner
|
Thanks for this @eleuven. Looking over your code here reminds me that the ylab logic is a little convoluted and could have been simplified as part of our new type system refactor. Let me take a stab at doing this in a separate PR and also role in some additional histogram arguments (which would avoid having to resolve some annoying merge conflicts in the GitHub UI from our previous PR). |
Owner
|
Closing in favour of #296 |
Contributor
Author
|
thanks for fixing this!
… On 2 Feb 2025, at 18:56, Grant McDermott ***@***.***> wrote:
Thanks for this @eleuven <https://github.com/eleuven>.
Looking over your code here reminds me that the ylab logic is a little convoluted and could have been simplified as part of our new type system refactor. Let me take a stab at doing this in a separate PR and also role in some additional histogram arguments (which would avoid having to resolve some annoying merge conflicts in the GitHub UI from our previous PR).
—
Reply to this email directly, view it on GitHub <#289 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMMBB7SY3GPY5KHNW5JHH32NZL5BAVCNFSM6AAAAABVXMPRLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRZGQ4TEMJVHE>.
You are receiving this because you were mentioned.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title says it all...