Merged
Conversation
grantmcdermott
added a commit
that referenced
this pull request
Nov 20, 2025
grantmcdermott
added a commit
that referenced
this pull request
Nov 20, 2025
* force legend eval to avoid downstream symbol (promise) issue * also need list handler * move `sanitize_legend` to own file while we're at it (like other sanitizers) * fix test errors * simplify sanitize_legend * ancilliary simplification * add test * test for #513 while we're at it * news
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #511
Created on 2025-11-19 with reprex v2.1.1
Two notes:
add = TRUE). We skip those cases now per cb6c156.addcases—I'm coercing to numeric before getting the axis range in lim.R. This seems to work fine and doesn't break any tests; partly because we already coerce characterxandyvariables to factors in sanitize_data.R. But I'm flagging it as a mental touch point in case it does end up breaking something down the line.