Skip to content

Pass by reference #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romanbsd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass by reference #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions json.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ namespace json
*
* @see json::jobject::parse(const char*)
*/
static inline jobject parse(const std::string input) { return parse(input.c_str()); }
static inline jobject parse(const std::string& input) { return parse(input.c_str()); }

/*! /brief Attempts to parse the input string
*
Expand Down Expand Up @@ -656,10 +656,10 @@ namespace json
}

/*! \brief Comparison operator */
bool operator== (const std::string other) const { return ((std::string)(*this)) == other; }
bool operator== (const std::string& other) const { return ((std::string)(*this)) == other; }

/*! \brief Comparison operator */
bool operator!= (const std::string other) const { return !(((std::string)(*this)) == other); }
bool operator!= (const std::string& other) const { return !(((std::string)(*this)) == other); }

/*! \brief Casts the value as an integer */
operator int() const;
Expand Down Expand Up @@ -809,7 +809,7 @@ namespace json
*
* @param value The entry value to copy
*/
inline const_value(std::string value)
inline const_value(const std::string& value)
: data(value)
{ }

Expand Down Expand Up @@ -945,7 +945,7 @@ namespace json
{ }

/*! \brief Assigns a string value */
inline void operator= (const std::string value)
inline void operator= (const std::string& value)
{
this->sink.set(this->key, json::parsing::encode_string(value.c_str()));
}
Expand Down