Only check write permission for stdout/stderr if path is absolute #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For relative paths stdout/stderr are relative to the job's working directory which is writable, so the check is redundant. The current check instead tests if the user's home directory is writable which is irrelevant. The test also creates and leaves behind a zero-length file in the user's home directory. The test also gives false failures if the user's home directory is not writable. Fixes https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1103552
ellert
force-pushed
the
only-check-absolute
branch
from
f8ee18a to
c6c0a07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For relative paths stdout/stderr are relative to the job's working directory which is writable, so the check is redundant.
The current check instead tests if the user's home directory is writable which is irrelevant. The test also creates and leaves behind a zero-length file in the user's home directory. The test also gives false failures if the user's home directory is not writable.
Fixes https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1103552